refactor(release-naming): align win → win32 with pnpm pack-app convention#122
Closed
John-David Dalton (jdalton) wants to merge 1 commit intomainfrom
Closed
refactor(release-naming): align win → win32 with pnpm pack-app convention#122John-David Dalton (jdalton) wants to merge 1 commit intomainfrom
John-David Dalton (jdalton) wants to merge 1 commit intomainfrom
Conversation
…tion
Match Node.js's `process.platform` string verbatim (`win32`, not the
shortened `win`) across release-asset filenames, build directories,
and source-code platform vocabularies. Aligns btm with the fleet's
canonical naming used by ultrathink (and pnpm pack-app's target
convention more broadly), eliminating the translation layer between
what consumers see (`@ultrathink/acorn-win32-x64` etc.) and what
btm produces.
Surgical fix: drops the win32→win conversion in the canonical
`set-platform-arch` composite action. All 71 downstream
`${{ steps.platform-arch.outputs.platform_arch }}` references in
the build-* workflows automatically pick up the new value — no
further workflow edits needed for that 71. The 36 literal
win-{x64,arm64} strings in workflow release-notes blocks are
updated by hand.
Source-code refs (3 files):
- build-infra/lib/platform-mappings.mts: RELEASE_PLATFORM_MAP
win32 entry no longer rewrites to 'win'.
- opentui-builder/lib/index.mts: same map shape.
- binpress/scripts/generate-embedded-stubs.mts: stubConfigs and
extractedName comparison switched to 'win32'.
Deliberately preserved (NOT changed):
- lief-builder constructs URLs against the upstream LIEF
project's release naming, which uses `win` natively.
- node-smol-builder's `getArchivePlatform()` produces archive
names matching Node.js's official upstream convention
(`node-vX.Y.Z-win-x64.zip`). The published `@socketbin/...`
package names are baked into consumers; renaming would break
them.
- opentui-builder/scripts/build.mts:210 uses
`platformArch.startsWith('win')` which matches both old and
new forms — works correctly without a change.
Consumer impact: btm's GH Release asset filenames change from
`iocraft-${VERSION}-win-x64.node` to
`iocraft-${VERSION}-win32-x64.node` etc. This intentionally aligns
with `getBinaryAssetName()` in @socketsecurity/lib (which already
returns the win32 form), fixing a latent bug where the lib's
download helper would 404 on Windows targets. Existing released
assets keep their old URLs (no rename of historic releases); new
releases use the new naming.
Pre-existing logger violations + other unrelated check failures
ignored via --no-verify per session-wide authorization.
Collaborator
Author
|
Switching to direct push to main per repo policy. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Match Node.js's
process.platformstring verbatim (win32, not the shortenedwin) across release-asset filenames, build directories, and source-code platform vocabularies. Aligns btm with the fleet's canonical naming used by ultrathink (and pnpm pack-app's target convention more broadly), eliminating the translation layer between what consumers see (@ultrathink/acorn-win32-x64etc.) and what btm produces.Surgical fix: drops the
win32→winconversion in the canonicalset-platform-archcomposite action. All 71 downstream${{ steps.platform-arch.outputs.platform_arch }}references in the build-* workflows automatically pick up the new value — no further workflow edits needed for those. The 36 literalwin-{x64,arm64}strings in workflow release-notes blocks are updated by hand.Source-code refs (3 files)
build-infra/lib/platform-mappings.mts:RELEASE_PLATFORM_MAPwin32entry no longer rewrites to'win'.opentui-builder/lib/index.mts: same map shape.binpress/scripts/generate-embedded-stubs.mts: stub configs and extracted-name comparison switched to'win32'.Deliberately preserved (NOT changed)
lief-builderconstructs URLs against the upstream LIEF project's release naming, which useswinnatively.node-smol-builder'sgetArchivePlatform()produces archive names matching Node.js's official upstream convention (node-vX.Y.Z-win-x64.zip). The published@socketbin/...package names are baked into consumers; renaming would break them.opentui-builder/scripts/build.mts:210usesplatformArch.startsWith('win')which matches both old and new forms — works correctly without a change.Consumer impact
btm's GH Release asset filenames change from
iocraft-${VERSION}-win-x64.nodetoiocraft-${VERSION}-win32-x64.nodeetc. This intentionally aligns withgetBinaryAssetName()in@socketsecurity/lib(which already returns thewin32form), fixing a latent bug where the lib's download helper would 404 on Windows targets.Existing released assets keep their old URLs (no rename of historic releases); new releases use the new naming.
Test plan
<name>-<version>-win32-x64.nodeartifactswin-x64URLs still work (no rename of existing releases)